chore: remove IsDedekindDomainDvr - #42367
Conversation
PR summary 540ac82250Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (weak) |
|---|---|---|
| 32 | -1 | disabled overlappingInstances linter |
Current commit 540ac82250
Reference commit 1f8806b67d
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
| `IsDedekindDomain` implies the localization at each nonzero prime ideal is a DVR. | ||
| - `IsDedekindDomain.isDedekindDomainDvr` is one direction of the equivalence of definitions | ||
| of a Dedekind domain | ||
| - `isDedekindDomain_iff_isDiscreteValuationRing_atPrime` proves the equivalece of |
There was a problem hiding this comment.
| - `isDedekindDomain_iff_isDiscreteValuationRing_atPrime` proves the equivalece of | |
| - `isDedekindDomain_iff_isDiscreteValuationRing_atPrime` proves the equivalence of |
| IsLocalization.AtPrime.isDiscreteValuationRing_of_dedekind_domain A hP _ | ||
| end | ||
|
|
||
| def IsDedekindDomainDvr [IsDomain A] : Prop := |
There was a problem hiding this comment.
So you think we still need this as a def?
Remove
IsDedekindDomainDvr, because is the same asIsDedekindDomain. See Zulip.