Skip to content

chore: golf some proofs with grw - #42440

Open
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-grw-golf-4
Open

chore: golf some proofs with grw#42440
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-grw-golf-4

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

Use grw/gcongr to golf some proofs. Additionally, deprecate ENNReal.coe_le_coe_of_le/ENNReal.coe_lt_coe_of_lt, as gcongr can now be used on iff lemmas.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR summary 391ad988ce

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 391ad98).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 391ad988ce
Reference commit 9fb10993c1

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg

grunweg commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Looks very nice, thanks! You have one build failure, though.

@grunweg grunweg added awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Aug 4, 2026
@grunweg grunweg self-assigned this Aug 4, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 4, 2026
@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 4, 2026
@grunweg

grunweg commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Thanks!
bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 4, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 4, 2026
Use `grw`/`gcongr` to golf some proofs. Additionally, deprecate `ENNReal.coe_le_coe_of_le`/`ENNReal.coe_lt_coe_of_lt`, as `gcongr` can now be used on iff lemmas.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants