You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously, those two files used apostrophes ' for discerning the point-free or applied lemmas, in a non-consistent way. I changed the naming to use _apply to name the applied versions.
For birkhoffSum, the birkhoffSum_add and birkhoffSum_add' lemma names were inconsistent with birkhoffSum_sub. _add is now function addition g + g' (matching _sub and birkhoffAverage_add), and _add' is now index addition m + n.
Another cases of inconsistency was that the n was sometimes present in in the non-applied version, sometimes not. I changed it to generalize the n (not mention it) in the non-applied whenever possible.
I also added some missing point-free versions.
I did not add deprecation aliases as there are currently no other files using those lemmas, and since many names are swapped I'm not sure if adding deprecations is even possible.
Created with the help of Claude, iteratively reviewed by me.
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>
The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit f86882c).
The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, those two files used apostrophes
'for discerning the point-free or applied lemmas, in a non-consistent way. I changed the naming to use_applyto name the applied versions.For
birkhoffSum, thebirkhoffSum_addandbirkhoffSum_add'lemma names were inconsistent withbirkhoffSum_sub._addis now function additiong + g'(matching_subandbirkhoffAverage_add), and_add'is now index additionm + n.Another cases of inconsistency was that the
nwas sometimes present in in the non-applied version, sometimes not. I changed it to generalize then(not mention it) in the non-applied whenever possible.I also added some missing point-free versions.
I did not add deprecation aliases as there are currently no other files using those lemmas, and since many names are swapped I'm not sure if adding deprecations is even possible.
Created with the help of Claude, iteratively reviewed by me.