Skip to content

chore(Algebra/Homology/HomotopyCategory/Shift): clean up most of set_options - #42448

Open
Whysoserioushah wants to merge 6 commits into
leanprover-community:masterfrom
Whysoserioushah:edison/cleanupShift
Open

chore(Algebra/Homology/HomotopyCategory/Shift): clean up most of set_options#42448
Whysoserioushah wants to merge 6 commits into
leanprover-community:masterfrom
Whysoserioushah:edison/cleanupShift

Conversation

@Whysoserioushah

@Whysoserioushah Whysoserioushah commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

If we want every set_option gone from this file, especially gone from this instance: CategoryTheory.Functor.commShiftMapCochainComplex then we need to set the reducibility of Functor.mapHomologicalComplex into reducible, this together with ContCohomology may indicate that we want it as an abbrev.


Open in Gitpod

@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR summary f1c5dfd630

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f1c5dfd).

  • +2 new declarations
  • −0 removed declarations
+CochainComplex.HomComplex.Cochain.leftShiftAddEquiv.congr_simp
+CochainComplex.HomComplex.Cochain.rightShiftAddEquiv.congr_simp

Decrease in strong tech debt: (relative, absolute) = (12.76, 0.01)
Current number Change Type (strong)
4351 -15 backward.defeqAttrib.useBackward
6969 -14 backward.isDefEq.respectTransparency
3977 -10 backward.isDefEq.respectTransparency.types
No changes to weak technical debt.

Current commit f1c5dfd630
Reference commit 20a3b032e0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 4, 2026
Comment thread Mathlib/Algebra/Homology/HomotopyCategory/Shift.lean Outdated
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 4, 2026
@Whysoserioushah Whysoserioushah removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 5, 2026
@Whysoserioushah

Copy link
Copy Markdown
Collaborator Author

!radar

@leanprover-radar

leanprover-radar commented Aug 5, 2026

Copy link
Copy Markdown

Benchmark results for f1c5dfd against 20a3b03 are in. No significant results found. @Whysoserioushah

  • 🟥 build//instructions: +6.3G (+0.00%)

Small changes (2🟥)

  • 🟥 build/module/Mathlib.Algebra.Homology.HomotopyCategory.Shift//instructions: +2.4G (+11.52%)
  • 🟥 build/module/Mathlib.CategoryTheory.Sites.SheafCohomology.Basic//instructions: +2.9G (+7.15%)


set_option backward.isDefEq.respectTransparency.types false in
set_option backward.defeqAttrib.useBackward true in
attribute [local implicit_reducible] HomologicalComplex.eval

@joelriou joelriou Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be a global implicit_reducible definition. (Arguably, also HomotopyCategory.quotient below: but do not take too much time on that one as it may require lots of fixes.)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so too! But is that change better to be in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants