chore(Algebra/Homology/HomotopyCategory/Shift): clean up most of set_options - #42448
chore(Algebra/Homology/HomotopyCategory/Shift): clean up most of set_options#42448Whysoserioushah wants to merge 6 commits into
Conversation
PR summary f1c5dfd630Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 4351 | -15 | backward.defeqAttrib.useBackward |
| 6969 | -14 | backward.isDefEq.respectTransparency |
| 3977 | -10 | backward.isDefEq.respectTransparency.types |
Current commit f1c5dfd630
Reference commit 20a3b032e0
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
!radar |
|
Benchmark results for f1c5dfd against 20a3b03 are in. No significant results found. @Whysoserioushah
Small changes (2🟥)
|
|
|
||
| set_option backward.isDefEq.respectTransparency.types false in | ||
| set_option backward.defeqAttrib.useBackward true in | ||
| attribute [local implicit_reducible] HomologicalComplex.eval |
There was a problem hiding this comment.
I believe this should be a global implicit_reducible definition. (Arguably, also HomotopyCategory.quotient below: but do not take too much time on that one as it may require lots of fixes.)
There was a problem hiding this comment.
I believe so too! But is that change better to be in another PR?
If we want every
set_optiongone from this file, especially gone from this instance:CategoryTheory.Functor.commShiftMapCochainComplexthen we need to set the reducibility ofFunctor.mapHomologicalComplexinto reducible, this together with ContCohomology may indicate that we want it as anabbrev.