Skip to content

chore: make norm_num normalize negative rationals as -a / b - #42498

Open
plp127 wants to merge 2 commits into
leanprover-community:masterfrom
plp127:aliu/norm_neg_rat
Open

chore: make norm_num normalize negative rationals as -a / b#42498
plp127 wants to merge 2 commits into
leanprover-community:masterfrom
plp127:aliu/norm_neg_rat

Conversation

@plp127

@plp127 plp127 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Make norm_num normalize negative rationals as -a / b instead of -(a / b). This is consistent with how #eval and ring_nf do them. See Zulip.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

PR summary 2b349828df

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 2b34982).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 2b349828df
Reference commit 7a1f8433f1

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants