chore(Analysis/SpecialFunctions/Pow/Real): deprecate six misnamed duplicate log/rpow lemmas - #42533
chore(Analysis/SpecialFunctions/Pow/Real): deprecate six misnamed duplicate log/rpow lemmas#42533attilavjda wants to merge 2 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 5d62747e76Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
Instead of deprecating them, can we change them to the correct statement right away? |
One reason I know of for waiting a deprecation cycle before repurposing these lemmas is that they might have callers outside Mathlib, and fixing them results in new lemmas, so if we fix them now those callers will use a different lemma than intended without their users knowing about the change. |
6
Pow/Real.leanlemmas duplicate with misleading names, replace by deprecated aliasesSome of these deprecated lemmas names, or their intended proofs seem mixed up too, which could be updated perhaps after the deprecation period?
Used Aristotle in making this PR. It found the duplicates, generated guidance, example code, and verifications.