Skip to content

refactor(Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Order): clean up hypotheses - #42545

Open
j-loreaux wants to merge 1 commit into
leanprover-community:masterfrom
j-loreaux:cfc-order-autoparams
Open

refactor(Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Order): clean up hypotheses#42545
j-loreaux wants to merge 1 commit into
leanprover-community:masterfrom
j-loreaux:cfc-order-autoparams

Conversation

@j-loreaux

Copy link
Copy Markdown
Contributor

Open in Gitpod

@j-loreaux
j-loreaux requested a review from themathqueen August 7, 2026 17:44
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR summary d1dde30f35

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ inr_le_inr_iff
+ inr_lr_inr
+ inr_nonneg
+ le_of_inr
+ nonneg_of_inr

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit d1dde30).

  • +5 new declarations
  • −0 removed declarations
+Unitization.inr_le_inr_iff
+Unitization.inr_lr_inr
+Unitization.inr_nonneg
+Unitization.le_of_inr
+Unitization.nonneg_of_inr

No changes to strong technical debt.

No changes to weak technical debt.

Current commit d1dde30f35
Reference commit 1c3257b287

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Aug 7, 2026

@[deprecated (since := "2026-08-06")] alias inr_le_iff := inr_le_inr_iff

lemma inr_lr_inr {a b : A} (hab : a ≤ b) (ha : IsSelfAdjoint a := by cfc_tac)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma inr_lr_inr {a b : A} (hab : a ≤ b) (ha : IsSelfAdjoint a := by cfc_tac)
lemma inr_le_inr {a b : A} (hab : a ≤ b) (ha : IsSelfAdjoint a := by cfc_tac)

exact spectrum_nonneg_of_nonneg (Unitization.inr_nonneg_iff.mpr ha) hx

lemma norm_le_norm_of_nonneg_of_le {a b : A} (ha : 0 ≤ a := by cfc_tac) (hab : a ≤ b) :
lemma norm_le_norm_of_nonneg_of_le {a b : A} (hab : a ≤ b) (ha : 0 ≤ a := by cfc_tac) :

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be renamed to norm_le_norm_of_le_of_nonneg? and same thing below for the nnnorm version

· exact isSelfAdjoint_inr (R := ℂ) |>.mp <| .of_nonneg h
· exact .of_nonneg h

lemma inr_nonneg (a : A) (ha : 0 ≤ a) : 0 ≤ (a : A⁺¹) := inr_nonneg_iff.mpr ha

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this exactly Unitization.LE.le.inr?
and the same below, isn't it just Unitization.LE.le.of_inr?

rw [← inr_le_inr_iff _ _]
simpa using hf₂.2 hx hy ha hb hab

alias ⟨LE.le.of_inr, LE.le.inr⟩ := inr_nonneg_iff

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this alias up next to the inr_nonneg_iff lemma?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants