Skip to content

refactor(Topology/Compactness): use Disjoint in closed-subfamily compactness lemmas - #42548

Open
FrankieNC wants to merge 1 commit into
leanprover-community:masterfrom
FrankieNC:disjoint-compacts
Open

refactor(Topology/Compactness): use Disjoint in closed-subfamily compactness lemmas#42548
FrankieNC wants to merge 1 commit into
leanprover-community:masterfrom
FrankieNC:disjoint-compacts

Conversation

@FrankieNC

@FrankieNC FrankieNC commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Resolve the three -- TODO: reformulate using Disjoint comments in Mathlib/Topology/Compactness/Compact.lean by restating

  • IsCompact.elim_directed_family_closed
  • IsCompact.elim_finite_subfamily_closed
  • isCompact_of_finite_subfamily_closed
  • isCompact_iff_finite_subfamily_closed

with Disjoint s (⋂ i, t i) in place of s ∩ ⋂ i, t i = ∅.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR summary b6bb7539db

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b6bb753).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit b6bb7539db
Reference commit 9fb10993c1

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant