Skip to content

refactor(Topology/Compactness): use 𝓝ˢ in exists_subset_nhds_of_isCompact' - #42550

Open
FrankieNC wants to merge 1 commit into
leanprover-community:masterfrom
FrankieNC:compact-nhdsSet-todo
Open

refactor(Topology/Compactness): use 𝓝ˢ in exists_subset_nhds_of_isCompact'#42550
FrankieNC wants to merge 1 commit into
leanprover-community:masterfrom
FrankieNC:compact-nhdsSet-todo

Conversation

@FrankieNC

@FrankieNC FrankieNC commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Change the hypothesis of exists_subset_nhds_of_isCompact' from ∀ x ∈ ⋂ i, V i, U ∈ 𝓝 x to U ∈ 𝓝ˢ (⋂ i, V i), as suggested by a TODO comment, and do the same for the variants exists_subset_nhds_of_isCompact and exists_subset_nhds_of_compactSpace.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR summary 8e7cc19ccc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 8e7cc19).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 8e7cc19ccc
Reference commit 87adeaebd3

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant