Merged
Conversation
benjaoming
force-pushed
the
log-rotation
branch
from
2bd32d5 to
20da832
Compare
benjaoming
force-pushed
the
log-rotation
branch
from
20da832 to
9e497df
Compare
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5449 +/- ##
==========================================
+ Coverage 61.39% 61.39% +<.01%
==========================================
Files 118 118
Lines 6574 6577 +3
==========================================
+ Hits 4036 4038 +2
- Misses 2538 2539 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
The lack of coverage in |
Contributor
Author
|
Merging this in due time for 0.17.1 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a new feature, but I'm going for 0.17.1 because it's super important to have logs for stuff.. especially tech support.
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
We might wanna make extra sure that this works on Windows, but I don't think there's a lot to review here.. I've manually tried it out, and it works :) But all the tests will end up logging things, too!
Issues addressed
#4890