[CI] test-migration: install+createdb+restore in one step (survive per-step-container runners) - #111
Merged
Merged
Conversation
…r-step-container runners)
dnplkndll
added a commit
that referenced
this pull request
Jun 19, 2026
…r-step-container runners) (#111)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Both migration-test workflows (
test-migration.ymlbaseline +test-migration-enriched.yml) previously split DB provisioning across separate steps: Install postgresql-client → Raise lock limit → DB Creation (createdb) → DB Restore. On a subset of the "oca forks" self-hosted runners eachrun:step gets a fresh container, so the client installed in the first step is gone bycreatedb→createdb: command not found(exit 127) and the whole migration test fails for reasons unrelated to the code under test.This folds install → lock-limit →
createdb→ restore into a single step per workflow, so the client is guaranteed present where it's used regardless of runner step-container behavior.PATHvia in-stepexportinstead of$GITHUB_PATH(which only affects later steps, useless inside one step) —pg_restorestill reads the PG16 dump.cloud_storage_googleskip and lock-limit raise are unchanged.Scope
This hardens the authoritative gate — the
ledoent/aggregatedpushes and the enriched run. The per-PRtest-migration(PR → base19.0) executes OCA's stock workflow, which has no client-install step at all; that flake is OCA-side and not addressed here. Per-PRtests+pre-commitremain the reliable per-PR signals.YAML validated; merged-step parses and contains no leftover split steps.