Add tiny docker-compose rebuild script#2039
Merged
rolandshoemaker merged 4 commits intomasterfrom Jul 13, 2016
Merged
Conversation
docker-rebuild.sh
Outdated
| # stop any running boulder containers | ||
| docker-compose stop boulder | ||
| # rebuild anything that has changed since the last run | ||
| docker-compose build boulder |
Contributor
There was a problem hiding this comment.
Should this just be docker-compose build to future proof in case we introduce new buildable images?
Contributor
|
Could you include the README updates in this diff. Also our comment style is generally Initial caps with a period. At least if the comment is a full sentence. |
docker-rebuild.sh
Outdated
| docker-compose stop | ||
| # Rebuild anything that has changed since the last run | ||
| docker-compose build | ||
| # Ff docker-compose run is used before using `up -d` docker will |
Contributor
|
LGTM |
Contributor
|
LGTM as well 🍹. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For rebuilding when base images change, will also add some extra detail to
README.mddetailing when/why it should be used.