Return descriptive error when SCT policy can't be met.#3586
Merged
Conversation
This commit updates CTPolicy & the RA to return a distinct error when the RA is unable to fetch the required SCTs for a certificate when processing an issuance. This error type is plumbed up to the WFE/WFE2 where the `web/probs.go` code converts it into a server internal error with a suitable user facing error.
jsha
reviewed
Mar 22, 2018
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Rather than define a new berrors type, wouldn't it be easier to return a berrors.ServerInternal? That should get the detail passed through to the frontend.
Contributor
Author
@jsha I thought that we stripped the msg from |
Contributor
|
Aha, you are correct! Thanks. |
jsha
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates CTPolicy & the RA to return a distinct error when
the RA is unable to fetch the required SCTs for a certificate when
processing an issuance. This error type is plumbed up to the WFE/WFE2
where the
web/probs.gocode converts it into a server internal errorwith a suitable user facing error.
Resolves #3546