Remove various unnecessary uses of fmt.Sprintf#3707
Merged
rolandshoemaker merged 1 commit intoletsencrypt:masterfrom May 11, 2018
Merged
Remove various unnecessary uses of fmt.Sprintf#3707rolandshoemaker merged 1 commit intoletsencrypt:masterfrom
rolandshoemaker merged 1 commit intoletsencrypt:masterfrom
Conversation
Remove various unnecessary uses of fmt.Sprintf - in particular:
- Avoid calls like t.Error(fmt.Sprintf(...)), where t.Errorf can be used directly.
- Use strconv when converting an integer to a string, rather than using
fmt.Sprintf("%d", ...). This is simpler and can also detect type errors at
compile time.
- Instead of using x.Write([]byte(fmt.Sprintf(...))), use fmt.Fprintf(x, ...).
4a6f656c
changed the title
jsha
approved these changes
May 11, 2018
rolandshoemaker
approved these changes
May 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove various unnecessary uses of
fmt.Sprintf.Avoid calls like
t.Error(fmt.Sprintf(...)), wheret.Errorfcan be used directly.Use
strconvwhen converting an integer to a string, rather than usingfmt.Sprintf("%d", ...). This is simpler and can also detect type errors atcompile time.
Instead of using
x.Write([]byte(fmt.Sprintf(...))), usefmt.Fprintf(x, ...).