CI: Ignore Godeps 'Comment' fields in godep-restore.#3744
Merged
Conversation
In preparation of `vgo` it seems many upstream projects are adding new tags. This is causing variations in the `godep-restore` phase of CI when the CI Godeps picks up a new `Comment` field that isn't present in the committed JSON. This has broken master ~3 times now and so it seems prudent to ignore the Comment field entirely for the short term. We continue to wait for the glorious day in which we can switch to `vgo` and never muck with `Godeps.json` again....
jsha
approved these changes
Jun 4, 2018
Contributor
|
Test-only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of
vgoit seems many upstream projects are adding newtags. This is causing variations in the
godep-restorephase of CI whenthe CI Godeps picks up a new
Commentfield that isn't present in thecommitted JSON. This has broken master ~3 times now and so it seems
prudent to ignore the Comment field entirely for the short term. We
continue to wait for the glorious day in which we can switch to
vgoand never muck with
Godeps.jsonagain....