Deconflict netaccess and boulder containers.#3785
Merged
Conversation
Since these two containers were using the same entrpoint.sh, they were competing to run migrations and bind ports when run with `docker-compose up`. Since we don't need the netaccess container when doing `docker-compose up`, give it a separate entrypoint that exits immediately by default, but does the normal migrations when run with `docker-compose run`.
rolandshoemaker
previously approved these changes
Jun 29, 2018
cpu
suggested changes
Jun 29, 2018
Contributor
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
one small nit, otherwise LGTM
test/entrypoint-netaccess.sh
Outdated
| # Otherwise it would race with boulder container's entrypoint.sh to run | ||
| # migrations, and one or the other would fail randomly. Also, it would compete | ||
| # with the boulder container for ports. This is a variant of entrypoint.sh that | ||
| # exists if it is not given an argument. |
cpu
approved these changes
Jun 29, 2018
Contributor
|
Merging with 1 🔍 - test only diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since these two containers were using the same entrypoint.sh, they were
competing to run migrations and bind ports when run with
docker-compose up. Since we don't need the netaccess container when doingdocker-compose up, give it a separate entrypoint that exitsimmediately by default, but does the normal migrations when run with
docker-compose run.