Conversation
ctpolicy permutes logs before submitting to them, to give each log a chance. The stagger feature was meant to sleep for an amount of time proportional to a log's position in the permuted list. However, it was actually using the log's position in the un-permuted list, so logs that appear later in the config would always be submitted to later than logs earlier in the config. This fixes that, and does some minor variable renaming for clarity.
rolandshoemaker
approved these changes
Jul 13, 2018
Contributor
rolandshoemaker
left a comment
rolandshoemaker
left a comment
There was a problem hiding this comment.
LGTM, I think it'd be nice to have a unittest that verifies this behavior works as intended, but I'm not convinced it's 100% necessary to land this change.
cpu
approved these changes
Jul 16, 2018
Contributor
I agree it would be nice but given J.sha is OOO I think its fair to merge as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctpolicy permutes logs before submitting to them, to give each log a
chance. The stagger feature was meant to sleep for an amount of time
proportional to a log's position in the permuted list. However, it was
actually using the log's position in the un-permuted list, so logs that
appear later in the config would always be submitted to later than logs
earlier in the config.
This fixes that, and does some minor variable renaming for clarity.