Add authz2 expired-authz-purger tool#4226
Merged
rolandshoemaker merged 4 commits intomasterfrom May 30, 2019
Merged
Conversation
Contributor
|
Why is this its own binary rather than a flag on the existing EAP? |
Contributor
Author
It shares basically no common logic other than the typical tool boilerplate. Instead of adding a complex second mode to the existing tool that would require excising of the old mode when old style authorizations are deprecated I felt it made more sense to implement as a separate tool. This allows us to simply delete the existing tool when we deprecate old style authorizations, and makes the new code considerably easier to read and reason about. |
jsha
requested changes
May 24, 2019
cpu
suggested changes
May 24, 2019
sa/_db-next/migrations/20190524120239_AddAuthz2ExpiresIndex.sql
Outdated
Show resolved
Hide resolved
sa/_db-next/migrations/20190524120239_AddAuthz2ExpiresIndex.sql
Outdated
Show resolved
Hide resolved
cpu
approved these changes
May 24, 2019
jsha
approved these changes
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4188.