Fix pass-through of revoke reason in ocsp-updater.#4880
Merged
Conversation
rolandshoemaker
previously approved these changes
Jun 19, 2020
aarongable
reviewed
Jun 19, 2020
Contributor
Author
|
Added an integration test case and addressed @aarongable's feedback. |
aarongable
reviewed
Jun 19, 2020
aarongable
approved these changes
Jun 19, 2020
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM from the perspective of "test function looks appropriately like other existing test functions that presumably do what they say on the tin".
rolandshoemaker
approved these changes
Jun 19, 2020
This was referenced Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.