Simplify crl-updater's simultaneous gRPC streams#6419
Merged
aarongable merged 4 commits intomainfrom Sep 29, 2022
Merged
Conversation
jsha
previously approved these changes
Sep 29, 2022
beautifulentropy
approved these changes
Sep 29, 2022
jsha
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would stream CRL Entries directly from the SA's
response stream into the CA's request stream, and similarly
directly stream bytes from the CA's response stream into the
Storer's request stream.
Since we're seeing odd errors and inconsistencies in our gRPC
streaming metrics, simplify these to only conduct one stream at
a time. This should make our streaming and error semantics much
simpler, at the cost of memory usage in the updater.