Conversation
aarongable
reviewed
Feb 13, 2023
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
This seems like a good approach to me! In general, I have some slight trepidation about adding dependencies on //cmd/shell.go to so many packages outside //cmd/. We already do this in a few places (largely //observer/ and tests, but also a couple others), so it's probably fine. Just worth thinking critically about.
Contributor
|
I would recommend putting this in its own small package at the top level: //strictyaml/. Then the function can be |
jsha
previously approved these changes
Feb 13, 2023
aarongable
previously approved these changes
Feb 14, 2023
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM, with a comment about taking this a step further.
Member
Author
|
It was an oversight, I'll get that fixed up.
|
beautifulentropy
previously requested changes
Feb 14, 2023
aarongable
reviewed
Feb 15, 2023
pgporada
dismissed
beautifulentropy’s stale review
I believe I have addressed this comment.
beautifulentropy
previously requested changes
Feb 15, 2023
Member
beautifulentropy
left a comment
beautifulentropy
left a comment
There was a problem hiding this comment.
Looking good. I think we're super close on this.
aarongable
approved these changes
Feb 22, 2023
beautifulentropy
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a custom YAML unmarshaller in the
//strictyamlpackage based ongo-yaml/yaml v3with unique key detection enabled and ensures that target struct is able to contain all target fields.Fixes #3344.