Clean up and deprecate no wait for ready#8608
Merged
beautifulentropy merged 4 commits intoletsencrypt:mainfrom Feb 6, 2026
Merged
Clean up and deprecate no wait for ready#8608beautifulentropy merged 4 commits intoletsencrypt:mainfrom
beautifulentropy merged 4 commits intoletsencrypt:mainfrom
Conversation
beautifulentropy
requested changes
Feb 4, 2026
Member
beautifulentropy
left a comment
beautifulentropy
left a comment
There was a problem hiding this comment.
Thanks for the pull request! I have just a couple comments, that mostly come down to Wait-For-Ready being off by default for gRPC implementations, this is honored by grpc-go.
grpc/interceptors.go
Outdated
| // Disable wait for ready so RPCs will retry until deadline, even if all backends | ||
| // are down. | ||
| opts = append(opts, grpc.WaitForReady(cmi.waitForReady)) | ||
| opts = append(opts, grpc.WaitForReady(false)) |
Member
There was a problem hiding this comment.
With the configuration corresponding field deprecated, we can just remove this whole block.
grpc/interceptors.go
Outdated
| // because non-WaitForReady mode is most similar to the old AMQP RPC layer: If a | ||
| // client makes a request while all backends are briefly down (e.g. for a restart), | ||
| // the request doesn't necessarily fail. A backend can service the request if it | ||
| // comes back up within the timeout. Under gRPC the same effect is achieved by |
Member
There was a problem hiding this comment.
Here we can remove anything that talks about WaitForReady.
grpc/interceptors.go
Outdated
Comment on lines
397
to
399
| // Disable wait for ready so RPCs will retry until deadline, even if all backends | ||
| // are down. | ||
| opts = append(opts, grpc.WaitForReady(cmi.waitForReady)) | ||
| opts = append(opts, grpc.WaitForReady(false)) |
Member
There was a problem hiding this comment.
We can also remove this whole block.
grpc/interceptors_test.go
Outdated
Comment on lines
95
to
101
| func TestThereIsNoWaitForReady(t *testing.T) { | ||
| clientMetrics, err := newClientMetrics(metrics.NoopRegisterer) | ||
| test.AssertNotError(t, err, "creating client metrics") | ||
| ci := &clientMetadataInterceptor{ | ||
| timeout: time.Second, | ||
| metrics: clientMetrics, | ||
| clk: clock.NewFake(), | ||
| waitForReady: false, | ||
| timeout: time.Second, | ||
| metrics: clientMetrics, | ||
| clk: clock.NewFake(), |
Member
There was a problem hiding this comment.
This test can also be removed, we shouldn't test the default state.
cmd/config.go
Outdated
| // backends are down, it will wait until either one becomes available or the RPC | ||
| // times out. | ||
| // | ||
| // Deprecated: Is ignored and always never waits for ready |
Member
There was a problem hiding this comment.
Add a small note here so that we remember to come back and remove it completely.
Suggested change
| // Deprecated: Is ignored and always never waits for ready | |
| // Deprecated: This field no longer has any effect. | |
| // | |
| // TODO(#7843): Remove this field entirely once it is no longer referenced | |
| // in our production configuration. |
maen-bn
force-pushed
the
clean-up-and-deprecate-no-wait-for-ready
branch
from
a27560a to
76b4e74
Compare
jsha
approved these changes
Feb 6, 2026
beautifulentropy
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7843