Update draft-ietf-acme-dns-persist-00 support to 01#8725
Open
beautifulentropy wants to merge 1 commit intomainfrom
Open
Update draft-ietf-acme-dns-persist-00 support to 01#8725beautifulentropy wants to merge 1 commit intomainfrom
beautifulentropy wants to merge 1 commit intomainfrom
Conversation
Contributor
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
jsha
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft-01 adds accounturi as a required field in the challenge object, rather than expecting the client to derive it. Add an AccountURI field to core.Challenge (and to the vendored eggsampler/acme Challenge struct, to reflect an upstream PR) and populate it in prepChallengeForDisplay. Source the value from a new WFE config field, AccountURIPrefix, which must match the first entry of the VA's AccountURIPrefixes since that is the exact string the VA uses as the expected accounturi when validating the TXT record.
Leave the new AccountURIPrefix config field optional so existing deployments upgrade without a config change. When AccountURIPrefix is unset, omit the accounturi field from the challenge object, which produces a draft-00-compatible challenge. Track making the field required in Production via TODO(#8724).
Also, bump the remaining draft references/citations from 00 to 01.
Fixes #8690