Merged
Conversation
Also update tests that now fail due to updated runtime.
jsha
reviewed
Apr 24, 2026
Comment on lines
-530
to
-534
| { | ||
| "::1", | ||
| "[::1]:" + defaultDNSSvrPort, | ||
| false, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Because go1.26 makes url.Parse fail on strings with a colon in the host component, except for properly-bracketed IPv6 addrs:
https://go.dev/doc/go1.26#neturlpkgneturl
jsha
approved these changes
Apr 24, 2026
beautifulentropy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update tests that now fail due to updated runtime.
Although we don't yet rely on any go1.26 features, an upcoming PR will do so, and it feels more appropriate to separate these fixes from that larger PR.