ceremony: Add support for configuring cross-sign EKUs#8750
Merged
Conversation
ezekiel
previously approved these changes
May 9, 2026
Member
|
The ceremony tool readme requires an update for at least that line. |
pgporada
reviewed
May 9, 2026
jsha
requested changes
May 11, 2026
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Looks good with a couple of comment nits. Also: we should add some unittest cases for the new rejections added. And perhaps we can add a check that notBefore is before June 15, 2026 when EKU contains [serverAuth, clientAuth]?
Co-authored-by: Jacob Hoffman-Andrews <github@hoffman-andrews.com>
Contributor
|
I've updated this PR with a unittest for the behavior in general, plus a safety check on the notBefore date relative to Chrome's deadline for non-dedicated cross-signs, and a unittest for the safety check. Ready for re-review. |
aarongable
commented
May 11, 2026
Contributor
Author
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
Thanks for the tests, lgtm with one typo:
jsha
approved these changes
May 11, 2026
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Additional diff looks good to me.
ezekiel
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 2025-09-15, the CCADB policy requires that all subordinate CA certificates, including cross-signs of existing roots, must have an EKU extension. As of 2026-06-15, the Chrome policy will require that all new subordinate CA certificates only contain the tlsServerAuth EKU. This change allows us to configure the set of EKUs that will appear in a CA certificate, while restricting that selection per the aforementioned requirements.