Skip to content

cert-checker: Exit non-zero on check failure#8759

Merged
beautifulentropy merged 1 commit into
mainfrom
fix-cert-checker
May 26, 2026
Merged

cert-checker: Exit non-zero on check failure#8759
beautifulentropy merged 1 commit into
mainfrom
fix-cert-checker

Conversation

@beautifulentropy
Copy link
Copy Markdown
Member

Fixes #8748

@beautifulentropy beautifulentropy changed the title cert-checker: Exit 1 on check failure cert-checker: Exit non-zero on check failure May 26, 2026
@beautifulentropy beautifulentropy marked this pull request as ready for review May 26, 2026 15:00
@beautifulentropy beautifulentropy requested a review from a team as a code owner May 26, 2026 15:00
@github-actions
Copy link
Copy Markdown
Contributor

@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@aarongable aarongable requested review from a team and jsha and removed request for a team May 26, 2026 16:29
@jsha
Copy link
Copy Markdown
Contributor

jsha commented May 26, 2026

Note: The PR description says "Fixes #8748", but that issue also says:

> Ensure each of our test profiles is exercised by integration tests (otherwise, why have that profile in CI?).

We should either change the PR description to "Part of #8748", or file a separate issue to exercise the modern profile in CI.

@jsha
Copy link
Copy Markdown
Contributor

jsha commented May 26, 2026

Oop, nevermind - I see we do issue under the modern profile:

res, err = authAndIssue(client, key, idents, true, "modern")
test.AssertNotError(t, err, "failed to issue under modern profile")
test.AssertEquals(t, res.Order.Profile, "modern")
modern := res.certs[0]

@beautifulentropy beautifulentropy merged commit 2517a8f into main May 26, 2026
21 checks passed
@beautifulentropy beautifulentropy deleted the fix-cert-checker branch May 26, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: cert-checker does not error in integration tests

3 participants