Skip to content

ci: remediate zizmor finding#8768

Merged
aarongable merged 2 commits into
mainfrom
inahga/zizmor-finding
May 28, 2026
Merged

ci: remediate zizmor finding#8768
aarongable merged 2 commits into
mainfrom
inahga/zizmor-finding

Conversation

@inahga
Copy link
Copy Markdown
Contributor

@inahga inahga commented May 28, 2026

Remediates this finding.

 info[template-injection]: code injection via template expansion
  --> ./.github/workflows/cps-review.yml:65:36
   |
41 |         uses: actions/github-script@v9
   |         ------------------------------ action accepts arbitrary code
42 |         with:
43 |           script: |
   |           ------ via this input
...
65 |             const flagNames = '${{ steps.newflags.outputs.flagnames }}';
   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ may expand into attacker-controllable code
   |
   = note: audit confidence → Low

By storing the step output as an environment variable first, we avoid injecting directly into the script.

@inahga inahga marked this pull request as ready for review May 28, 2026 17:10
@inahga inahga requested a review from a team as a code owner May 28, 2026 17:10
@inahga inahga requested a review from beautifulentropy May 28, 2026 17:10
@github-actions

This comment was marked as outdated.

1 similar comment
@github-actions

This comment was marked as outdated.

@inahga
Copy link
Copy Markdown
Contributor Author

inahga commented May 28, 2026

The comment fired twice because I did two actions simultaneously that triggered it (move from draft + request review). Not new behavior.

@aarongable aarongable merged commit 0da6f7d into main May 28, 2026
17 checks passed
@aarongable aarongable deleted the inahga/zizmor-finding branch May 28, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants