Skip to content

ra: rewrite outdated comment#8782

Merged
jsha merged 1 commit into
mainfrom
fix-comments
Jun 5, 2026
Merged

ra: rewrite outdated comment#8782
jsha merged 1 commit into
mainfrom
fix-comments

Conversation

@jsha
Copy link
Copy Markdown
Contributor

@jsha jsha commented Jun 5, 2026

Also tweak two placed that are implicated or mention the outdated flows:

  • getSCTs can be inlined into the RPC method GetSCTs now that it is the only caller.
  • a unittest for tbsCertificateIsDeterministic mentioned ca.IssueCertificateForPrecertificate but doesn't need to.

And tweak issuance-cycle.md slightly:

  • don't mention selecting a profile, since this mostly happens before finalization
  • do mention submission of final certificates to CT

Also tweak two placed that are implicated or mention the outdated flows:

 - getSCTs can be inlined into the RPC method GetSCTs now that it is the only
   caller.
 - a unittest for tbsCertificateIsDeterministic mentioned
   ca.IssueCertificateForPrecertificate but doesn't need to.
@jsha jsha marked this pull request as ready for review June 5, 2026 16:55
@jsha jsha requested a review from a team as a code owner June 5, 2026 16:55
@jsha jsha requested a review from ezekiel June 5, 2026 16:55
@jsha jsha merged commit 1ea34f2 into main Jun 5, 2026
18 checks passed
@jsha jsha deleted the fix-comments branch June 5, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants