Restrict WFE account cache to POST-as-GET requests#8852
Open
aarongable wants to merge 4 commits into
Open
Conversation
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an argument to some of wfe2/verify.go's JWK-verification functions, which supplies the AccountGetter which should be used to look up the account. For all POST codepaths, supply wfe.sa (i.e. a connection to the real database) as the source. For all POST-as-GET codepaths, supply wfe.accountCache, to reduce database load from frequent-but-idempotent read-only requests.
This prevents situations where an account rotates its key, but a subsequent request using the same key is still able to make changes to the account (such as rotating the key again) due to the account cache.
Also add a new ability to purge entries from the account cache, and call it when accounts are deactivated or have their key rotated. This is an imperfect defense-in-depth measure, as multiple WFEs may have the old account data cached and only one WFE instance will see the request which triggers the cache purge, but it still helps reduce confusing behavior.
This is a simpler alternative to #8796, building on the diff introduced in that PR.
Fixes #8795
Fixes #6144