Move GenerateSKID into Core for sharing across ca, ceremony, and lints - #8922
Merged
Conversation
ezekiel
approved these changes
Jul 29, 2026
ezekiel
requested review from
a team and
beautifulentropy
and removed request for
a team
July 29, 2026 00:26
beautifulentropy
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new core.GenerateSKID function, which computes the Subject Key Identifier value in the way we want (a truncated hash). Use this to replace the two existing helper functions in the CA and Ceremony tool, and to prepare for additional usage inside our upcoming CP/CPS lints.
This moves some of the refactoring out of #8485, so that PR can be more focused on the lints themselves.