Fix ANR/crash in AndroidGraphics.destroy() due to infinite wait()#7699
Conversation
…rame never called
|
When will it be merged? I can see this bug in my console log too. |
tommyettinger
left a comment
There was a problem hiding this comment.
Apparently I reviewed these changes in an earlier PR and approved them. That PR couldn't be merged, so the review went away, but I'll still approve this one... even though I really don't do much Android stuff at all, and don't know if this will work or if it is still needed.
Does aprroved mean it will be merged into the master brach so we can get the update? |
obigu
left a comment
There was a problem hiding this comment.
The issue seems to only affect AndroidFragment based apps and the fix has been confirmed to work. Should be harmless for non Fragment apps.
Summary
This PR resolves an ANR/crash in
AndroidGraphics.destroy()(#7626) caused by an infinitewait()whenonDrawFrame()is never invokedTechnical Details
pause()method: it manually enqueues a call toonDrawFrame.destroy()can complete without blocking indefinitely.