Skip to content

Remove union merge driver for sln, csproj files#1063

Merged
nulltoken merged 1 commit intovNextfrom
ethomson/gitattributes
May 31, 2015
Merged

Remove union merge driver for sln, csproj files#1063
nulltoken merged 1 commit intovNextfrom
ethomson/gitattributes

Conversation

@ethomson
Copy link
Member

The union merge driver is not appropriate for sln or csproj files. It is useful (as described by Junio) to "merge two shopping lists".

This will work in trivial examples for sln and csproj files, for example when one branch adds a new file and the other branch does too, but it will often silently produce corrupt output.

@haacked has a nice writeup at http://haacked.com/archive/2014/04/16/csproj-merge-conflicts/

The union merge driver is not appropriate for sln or csproj
files.  It is useful (as described by Junio) to "merge two
shopping lists".

This will work in trivial examples for sln and csproj files,
for example when one branch adds a new file and the other branch
does too, but it will often silently produce corrupt output.
@shiftkey
Copy link
Contributor

👍

@nulltoken nulltoken added this to the v0.22 milestone May 31, 2015
nulltoken added a commit that referenced this pull request May 31, 2015
Remove union merge driver for sln, csproj files
@nulltoken nulltoken merged commit 2c98992 into vNext May 31, 2015
@nulltoken nulltoken deleted the ethomson/gitattributes branch May 31, 2015 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants