Update health monitor to also use better node matching logic#143
Merged
disrani-px merged 2 commits intonode_internalipfrom Sep 14, 2018
Merged
Update health monitor to also use better node matching logic#143disrani-px merged 2 commits intonode_internalipfrom
disrani-px merged 2 commits intonode_internalipfrom
Conversation
disrani-px
force-pushed
the
node_internalip_monitor
branch
from
4292d80 to
338e640
Compare
harsh-px
approved these changes
Sep 14, 2018
| // The driver might not return fully qualified hostnames, so check if the short | ||
| // hostname matches too | ||
| func isHostnameMatch(driverHostname string, k8sHostname string) bool { | ||
| if driverHostname == k8sHostname { |
There was a problem hiding this comment.
nit: can be made shorter with if driverHostname == k8sHostname || strings.HasPrefix(k8sHostname, driverHostname+".") {. Your call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated test verification