PWX-33049 : Adding SC parameter preferRemoteNode to disable Anti-HyperConvergence for sharedv4 service volumes#1515
Merged
olavangad-px merged 2 commits intomasterfrom Sep 27, 2023
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
olavangad-px
added
release-note
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
+ Coverage 65.13% 65.24% +0.11%
==========================================
Files 43 43
Lines 5183 5191 +8
==========================================
+ Hits 3376 3387 +11
+ Misses 1481 1479 -2
+ Partials 326 325 -1
☔ View full report in Codecov by Sentry. |
pp511
requested changes
Sep 25, 2023
Contributor
pp511
left a comment
pp511
left a comment
There was a problem hiding this comment.
Changes look good.
Just some nitpicking.
Release note suggestion:
New Feature
When StorageClass parameter "stork.libopenstorage.org/preferRemoteNode" is set to "false", Stork will disable anti-hyperconvergence for shared v4 service volumes created using this StorageClass and value of "stork.libopenstorage.org/preferRemoteNodeOnly" parameter will be ignored. Default value of "stork.libopenstorage.org/preferRemoteNode" is set to true.
…onvergence for sharedv4 service volumes Revision 2 : Addressed comments by @ppandey
olavangad-px
force-pushed
the
PWX-33049
branch
from
c23aa19 to
9fd6b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Introduce a new parameter stork.libopenstorage.org/preferRemoteNode to be applied to a StorageClass.
Default value of preferRemoteNode is true for pods using shared v4 service volumes and will prefer antihyperconvergence
If value of this label is set to false, ignore preferRemoteNodeOnly flag and prefer Hyperconvergence for pods using shared v4 service volumes.
For more details refer to PWX-33049
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
Yes, 23.11.0
Testing Details:
Notes For the Reviewer