Adding integration test for SC parameter preferRemoteNode set as false#1520
Merged
olavangad-px merged 5 commits intomasterfrom Oct 7, 2023
Merged
Adding integration test for SC parameter preferRemoteNode set as false#1520olavangad-px merged 5 commits intomasterfrom
olavangad-px merged 5 commits intomasterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
olavangad-px
added
the
integration-test
pp511
reviewed
Oct 3, 2023
Contributor
pp511
left a comment
pp511
left a comment
There was a problem hiding this comment.
Changes look ok.
Let's check on the testRailID and add it too.
Also you mentioned you ran integration tests. Is possible do add the link to the Jenkins job where you ran it.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
+ Coverage 65.18% 65.24% +0.05%
==========================================
Files 43 43
Lines 5191 5191
==========================================
+ Hits 3384 3387 +3
+ Misses 1481 1479 -2
+ Partials 326 325 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR includes commits to add integration tests for new feature added as part of PWX-33049 #1515
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
No
Does this change need to be cherry-picked to a release branch?:
Yes, 23.11.0
Testing details
Have run the updated integration test suite for extender in a jenkins job Jenkins Build Link