Skip to content

anygw: use dnsmasq host-record instead of address#654

Merged
ilario merged 1 commit intolibremesh:masterfrom
spiccinini:fix_wildcard_dns
Nov 28, 2019
Merged

anygw: use dnsmasq host-record instead of address#654
ilario merged 1 commit intolibremesh:masterfrom
spiccinini:fix_wildcard_dns

Conversation

@spiccinini
Copy link
Copy Markdown
Contributor

@spiccinini spiccinini commented Nov 26, 2019

This fixes dnsmasq returning the anycast address when the dns query
is for a host if dnsmasq does not know about it. For example
pepe.thisnode.info was returning the anycast address if pepe was not
known by dnsmasq (or only the ipv4 was known and the ipv6 was
requested).

This started to bite after #541

This is related to openwrt's:

dfea3bae11dd5c207182371ce1fdca763fb5bbe0
    Author: Jo-Philipp Wich <jow@openwrt.org>
    Date:   Mon Jun 17 11:55:30 2013 +0000

        dnsmasq: use host-record instead of address

        Using "--address" for individual host A records is broken, use
	"--host-record" instead.

before the fix:

$ dig +noall +answer  A @nodo2 bonzo
bonzo.            0    IN    A    10.133.xxx.204

$ dig +noall +answer AAAA @nodo2 bonzo

$ dig +noall +answer  A @nodo2 bonzo.thisnode.info
bonzo.thisnode.info.    0    IN    A    10.133.xxx.204

$ dig +noall +answer AAAA @nodo2 bonzo.thisnode.info 
bonzo.thisnode.info.    0    IN    AAAA    2a00:1508:a85:xxxx::1

This fixes dnsmasq returning the anycast address when the dns query
is for a host if dnsmasq does not know about it. For example
pepe.thisnode.info was returning the anycast address if pepe was not
known by dnsmasq (or only the ipv4 was known and the ipv6 was
requested).

This is related to openwrt's:
dfea3bae11dd5c207182371ce1fdca763fb5bbe0
    Author: Jo-Philipp Wich <jow@openwrt.org>
    Date:   Mon Jun 17 11:55:30 2013 +0000

        dnsmasq: use host-record instead of address

        Using "--address" for individual host A records is broken, use
	"--host-record" instead.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #654 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   73.03%   73.03%           
=======================================
  Files          25       25           
  Lines        1836     1836           
=======================================
  Hits         1341     1341           
  Misses        495      495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330ae4c...f33051f. Read the comment docs.

@spiccinini spiccinini added the bug label Nov 26, 2019
@ilario
Copy link
Copy Markdown
Member

ilario commented Nov 28, 2019

I confirm the issue, and I confirm that the fix works! Thanks!!!

@ilario ilario merged commit 5277d3b into libremesh:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants