anygw: use dnsmasq host-record instead of address#654
Merged
ilario merged 1 commit intolibremesh:masterfrom Nov 28, 2019
Merged
anygw: use dnsmasq host-record instead of address#654ilario merged 1 commit intolibremesh:masterfrom
ilario merged 1 commit intolibremesh:masterfrom
Conversation
This fixes dnsmasq returning the anycast address when the dns query
is for a host if dnsmasq does not know about it. For example
pepe.thisnode.info was returning the anycast address if pepe was not
known by dnsmasq (or only the ipv4 was known and the ipv6 was
requested).
This is related to openwrt's:
dfea3bae11dd5c207182371ce1fdca763fb5bbe0
Author: Jo-Philipp Wich <jow@openwrt.org>
Date: Mon Jun 17 11:55:30 2013 +0000
dnsmasq: use host-record instead of address
Using "--address" for individual host A records is broken, use
"--host-record" instead.
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 25 25
Lines 1836 1836
=======================================
Hits 1341 1341
Misses 495 495Continue to review full report at Codecov.
|
G10h4ck
approved these changes
Nov 26, 2019
Member
|
I confirm the issue, and I confirm that the fix works! Thanks!!! |
ilario
approved these changes
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes dnsmasq returning the anycast address when the dns query
is for a host if dnsmasq does not know about it. For example
pepe.thisnode.info was returning the anycast address if pepe was not
known by dnsmasq (or only the ipv4 was known and the ipv6 was
requested).
This started to bite after #541
This is related to openwrt's:
before the fix: