C89 compliance, lowercase naming, iOS fix, and core option enhancements #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the implementation of stb_image functions in a new source file, stb_image_impl.c. This file includes the necessary definitions to enable the functionality provided by the stb_image library. Only one C file should define STB_IMAGE_IMPLEMENTATION to avoid multiple definitions.
- Added comprehensive technical overview and visual reference documentation for the file browser feature. - Added support for various platforms, ensuring consistent behavior across Windows, Linux, macOS, Android, Switch, and Vita. - Included error handling strategies and performance considerations for efficient operation. - Updated build configurations to include new source files for different architectures (arm64-v8a, armeabi-v7a, riscv64, x86, x86_64).
- Created dependency files for various source files including cart.c, controller.c, cp1610.c, and others. - Updated dependencies for libretro-common components such as compat_posix_string.c, compat_snprintf.c, and file_path.c. - Included necessary headers for each source file to ensure proper compilation. - Enhanced project structure by organizing object files and their dependencies for better build management.
Added images and updated contributors section in README.
Added Ko-fi username for funding support.
… a 'core option'.
…for change to core option from separate core
…splay instructions
…splay name, supported extensions, and description
- Implement side-by-side dual-screen rendering (1074×600 workspace) - Add touchscreen hotspot input detection for 12 keypad buttons - Support ROM-specific PNG overlays (370×600 pixels) - Add cross-platform input handling (Android, Windows, Linux) - Include screen swap functionality - Update documentation with setup and usage instructions - Update core metadata and info file - Remove debug logging infrastructure - Maintain full backward compatibility
…erlays Add Dual-Screen Touchscreen and Overlay Support to FreeIntv Core
…ced onscreen interactive keypad overlays and improved versioning
…n default single screen mode.
…creen/mouse are required.
…rection remnants,
…ibility Android.mk LOCAL_MODULE was changed to 'freeintv' but buildbot expects 'libretro.so'. Reverting to 'retro' (last successful build at PR libretro#89) to match buildbot expectations. This produces libretro.so as expected by the build system.
Removed duplicate 'unsigned int util_bg_color' declaration at line 378 which conflicted with 'unsigned int utility_bg_color' at line 401. This was causing undeclared variable errors in PS2 builds.
Added missing declarations in render_multi_screen(): - overlay_pixel_val, pixel, base_pixel - inv_alpha, base_r/g/b, bg_r/g/b - ctrl_base_x_offset, overlay_x_offset, ctrl_x - r, g, b, existing_r/g/b - offset, corner_cut, border_colors array - util_border_x1/x2/y1/y2, hotspot_x_adjust, highlight_color - Changed utility_bg_color from int to unsigned int - Fixed util_bg_color references to use utility_bg_color
Changed 'int hotspot_x_adjust = ...' to 'hotspot_x_adjust = ...' at line 694 since the variable is already declared at the function start (line 406). C89 does not allow redeclaration within the same scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical compilation failures and introduces standardization improvements:
Changes
MSVC C89 Compliance Refactoring (libretro.c)
load_controller_base(),load_banner(),load_overlay_for_rom(),render_multi_screen()iOS Thread-Local Storage Fix (stb_image_impl.c)
STBI_THREAD_LOCALon Apple platforms for armv7 iOS 9 compatibilityLowercase Naming Standardization
Core Options Enhancement (libretro_core_options.h)
Testing
Impact
Resolves buildbot failures across multiple platforms: