Enable serial detection from GDI files.#16171
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Jan 28, 2024
Merged
Conversation
Contributor
|
What's the performance impact of this? Will it lead to much slower Dreamcast game scanning? |
Contributor
Author
|
No, GDI is a small file (like .cue) so that should not have any noticeable impact. |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-enable serial detection for GDI files. This was explicitly disabled in #5447 , but nowadays Dreamcast database is based on serials.
Verified with a scan, GDI file is getting detected correctly.