More scanning rework#5447
Merged
inactive123 merged 11 commits intolibretro:masterfrom Sep 19, 2017
bkoropoff:scanning2
Merged
Conversation
Contributor
Author
|
GDI files (and derived CHDs) seem to work. |
RobLoach
reviewed
Sep 18, 2017
| if (chd_get_serial(name, db_state->serial)) | ||
| /* There are no serial databases, so don't bother with | ||
| serials at the moment */ | ||
| if (0 && chd_get_serial(name, db_state->serial)) |
Member
There was a problem hiding this comment.
This will always skip? Should we just remove this code?
Contributor
Author
There was a problem hiding this comment.
It prevents an unused function warning, and makes it easy to enable later.
Contributor
Author
|
OK, it'll now avoid scanning tracks twice when scanning a directory. It'll also avoid scanning tracks that aren't used for identification. |
Contributor
|
Seems there is a merge conflict which needs fixing. |
- Use the primary (largest data) track for CRC identification, as it seems least likely to be shared among multiple discs - CRC the primary track when importing a loose .cue file. - If multiple tracks are in the same file, CRC the correct chunk
Scan them before the tracks so we can avoid scanning large files we don't need to.
Since we use cue/gdi files to find the right track file to scan, don't bother scanning them separately.
Contributor
Author
|
Rebased. The Travis failure is an apt-get problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurs to me that scanning a directory with both a cue and a data track in its own file will now detect both, which means the wrong one may end up getting added to the playlist. It also wastes a lot of time scanning binaries we don't care about, so this should probably be fixed by e.g. scanning cue files first, then removing any references files from the remainder of the list to be scanned. This, as well as GDI file support, will have to come later.
Sorry for some of the unintentional reformatting, I need to write a clang-format file for retroarch.