Skip to content

Extra mouse buttons#5691

Merged
inactive123 merged 2 commits intolibretro:masterfrom
hiddenasbestos:extra_mouse_buttons
Nov 17, 2017
Merged

Extra mouse buttons#5691
inactive123 merged 2 commits intolibretro:masterfrom
hiddenasbestos:extra_mouse_buttons

Conversation

@hiddenasbestos
Copy link
Copy Markdown
Contributor

Given the common occurrence of additional buttons on modern mice, I propose adding controls RETRO_DEVICE_ID_MOUSE_BUTTON_4 and RETRO_DEVICE_ID_MOUSE_BUTTON_5 to the set of constants.

Sega Saturn cores can map these to the required start button input on its official mouse, to more accurately represent the real hardware. Other cores, such as for ports of Doom and Quake would also benefit.

@inactive123
Copy link
Copy Markdown
Contributor

inactive123 commented Nov 17, 2017

Thanks for the contribution. I still see some platforms for which we need to add mouse 4/5 support (like Android/OSX/Linux), but I imagine you don't have access to those development environments so we could take care of this ourselves.

@Alcaro Seems like a fairly useful and trivial thing to add to libretro.h, got any last-minute objections or design consideration suggestions or do you think we could merge this as-is? I think it's fine to go as far as I'm concerned.

@Alcaro
Copy link
Copy Markdown
Contributor

Alcaro commented Nov 17, 2017

Mouse 4/5 are mouse wheel up/down on Linux, and possibly on other problems.

But there are wheel constants around there already, and anyone with a brain can figure out that linux-mouse4 does not trigger both of those, so I'm fine with this.

I would prefer if RETRO_DEVICE_ID_MOUSE_HORIZ_WHEELUP had a less weird name, like RETRO_DEVICE_ID_MOUSE_HORIZ_WHEELLEFT, but that's out of scope here.

@inactive123
Copy link
Copy Markdown
Contributor

OK, I am merging this then and also the PRs made to libretro-common, libretro-arb, and the saturn core.

@inactive123 inactive123 merged commit 1aa05de into libretro:master Nov 17, 2017
@anyputer
Copy link
Copy Markdown
Contributor

anyputer commented Nov 17, 2017

Yes! I was thinking about this an few days ago! :) Oh, and I feel it would be great if you could those buttons in the menu to return and go back to screens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants