SDL_SetWindowIcon for Emscripten

[LloydJHowarth]

Using SDL_SetWindowIcon is a very convenient cross-platform way to handle window based icons.

When using (C#)

    var icon = SDL_image.Load(Path.Combine(SDL.GetBasePath(), "Icon.png"));
    
    if (icon == null)
        throw new Exception("Failed to load icon: " + SDL.GetError());

    if (!SDL.SetWindowIcon(window, icon))
    {
        throw new Exception("Failed to set icon: " + SDL.GetError());
    }

There is an error:

System.Exception: Failed to set icon: That operation is not supported

We can load surfaces & textures through the Emscripten file system when using --embed-file so it would make sense to support this operation for Emscripten which should set the browser tab icon.

[slouken]

This seems like a good idea! If you have a PR that you have working, we can consider this for the 3.4 release.

[LloydJHowarth]

This seems like a good idea! If you have a PR that you have working, we can consider this for the 3.4 release.

Unfortunately I don't know enough C to play around otherwise I would. My knowledge only extends enough to write bindings for C# to use SDL that way...

I don't think emscripten has some "set icon" functionality built in from a quick search so you couldn't use that, it probably could however be added as some EM_JS method call to set the icon for simplicity and let emscripten handle the browser specifics

[icculus]

Yeah, I think you literally just change a <link> tag in the document on the fly to a new href (presumably with a blob URL we'll create on the fly).

Totally doable for 3.6.0, if I'm correct about this.

[icculus]

I'm going to stick this in 3.4.0, but if we run out of time, we'll bump to 3.6.0. But it would be nice to get this in, since we have other Emscripten improvements landing, too.

[ej-sanmartin]

I'll look into this @LloydJHowarth i mainly work in C++ and been using SDL3 in some of my recent projects.

Since 3.4.0 seems to be releasing soon, I'll try to cut a PR ASAP

[LloydJHowarth]

I'll look into this @LloydJHowarth i mainly work in C++ and been using SDL3 in some of my recent projects.

Since 3.4.0 seems to be releasing soon, I'll try to cut a PR ASAP

It works great, legend!!