windows: Allow OpenGL ES creation without EGL, if the WGL supports it. #14168
Conversation
Note that this should work with GLES1, don't let the "es2" in WGL_EXT_create_context_es2_profile fool you. Fixes libsdl-org#13056.
|
This is a draft because I haven't tested or even compiled this yet; do not merge yet! |
|
Okay, not only does this work, it makes testgles2 run on my Windows box, where it would fail to create a context at all before! (On Nvidia's latest drivers, the EGL path fails trying to load libGLESv2.dll, but it makes a GLES2 context just fine through WGL with the extension!) The only things that look like "libEGL.dll" or "libGLESv2.dll" are in web browser things: Firefox, Edge, CEF...I assume these are copies of ANGLE. It doesn't look like Nvidia ships an EGL with their drivers at all, so this patch is probably the only way to use "native" GLES2 on Windows. |
| return SDL_GetHintBoolean(SDL_HINT_OPENGL_ES_DRIVER, false) || _this->gl_config.major_version == 1 || _this->gl_config.major_version > _this->gl_data->es_profile_max_supported_version.major || (_this->gl_config.major_version == _this->gl_data->es_profile_max_supported_version.major && _this->gl_config.minor_version > _this->gl_data->es_profile_max_supported_version.minor); // No WGL extension for OpenGL ES 1.x profiles. | ||
| // (we don't need EGL to do OpenGL ES if HAS_WGL_EXT_create_context_es2_profile exists.) | ||
|
|
||
| return !_this->gl_data->HAS_WGL_EXT_create_context_es2_profile || SDL_GetHintBoolean(SDL_HINT_OPENGL_ES_DRIVER, false) || _this->gl_config.major_version == 1 || _this->gl_config.major_version > _this->gl_data->es_profile_max_supported_version.major || (_this->gl_config.major_version == _this->gl_data->es_profile_max_supported_version.major && _this->gl_config.minor_version > _this->gl_data->es_profile_max_supported_version.minor); // No WGL extension for OpenGL ES 1.x profiles. |
There was a problem hiding this comment.
Can you split this out into multiple lines for sanity?
There was a problem hiding this comment.
The actual problematic check is still in here also _this->gl_config.major_version == 1 || (without removing this gles1 profiles are still not able to be created)
|
Whoops, okay, fixing the GLES1 thing (and splitting it into multiple lines). |
3 participants
Note that this should work with GLES1, don't let the "es2" in WGL_EXT_create_context_es2_profile fool you.
Fixes #13056.