Clarify which thread is the main thread #14555
Merged
+106
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
force-pushed
the
mainthread
branch
2 times, most recently
from
99c434b to
3f2d09f
Compare
Collaborator
|
I feel like this whole thing has fallen into a "if you want to shoot yourself in the foot, here are the best practices" area. :) But since almost everything is just going to have a main() function that calls SDL_Init and does video stuff on that thread, if this helps the corner cases that refuse to, I'm cool with it. |
Collaborator
Author
Yeah... |
slouken
force-pushed
the
mainthread
branch
2 times, most recently
from
609fd38 to
c6bc60c
Compare
If video is initialized, the main thread is the one that initialized video, otherwise if events are initialized, the main thread is the thread that initialized events, otherwise the main thread is the one that called the main function. Fixes libsdl-org#14511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If video is initialized, the main thread is the one that initialized video, otherwise if events are initialized, the main thread is the thread that initialized events, otherwise the main thread is the one that called the main function.
Fixes #14511