chore: make typescript happy#344
Closed
DavidTanner wants to merge 1 commit intomasterfrom
Closed
Conversation
Contributor
|
@DavidTanner CI is failing on this PR. |
Contributor
|
@DavidTanner Also, I think I'm missing some context that other reviewers might have. What problem is being fixed by this PR? |
Contributor
Author
|
Was just trying to make the build happy. There are many dependabot builds failing. I'm not inclined to put much effort into keeping this project alive, I was just hoping this would help the automation. |
Contributor
|
@DavidTanner Ah, I see. My personal recommendation: since this project is not actively maintained, I'd just approve and merge the dependabot PRs (even though they are failing CI). That will at least clear them from your queue, and edit: won't resolve the security issue, but I'd propose that's low-priority anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just because there are so many projects still using this...