Conversation
mdlavin
commented
Sep 20, 2023
| const childLogger: Debugger = logger.extend(name); | ||
| childLogger.log = log || logger.log; | ||
| childLogger.enabled = enabled || logger.enabled; | ||
| if (enabled || logger.enabled) { |
Contributor
Author
There was a problem hiding this comment.
The old approach of explicitly enabling logging on a single logger broke with the upgraded debug package
| child: (name: string) => { | ||
| const child = root.extend(name); | ||
| child.enabled = root.enabled; | ||
| if (root.enabled) { |
Contributor
Author
There was a problem hiding this comment.
The old approach of explicitly enabling logging on a single logger broke with the upgraded debug package
Contributor
|
Looks good to me. |
swain
approved these changes
Sep 20, 2023
|
The following commits have not yet passed change management validation:
Created by |
|
🎉 This PR is included in version 16.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DavidTanner did all the work: #344