Separate Axelar from executor #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing NatSpec
0xDEnYO
added a commit
that referenced
this pull request
Oct 23, 2024
…ssFacetPackedV3 v1.0.0, ReceiverAcrossV3 v1.0.0) (#687) * Implment and add tests for LibUtil::revertWith() * remove unneeded import * deploy to staging * temp - DO NOT PUSH * split facets, test files, deploy scripts etc. to V1/V3 * fix: replaces address parameter in facet * tests fixed * demoscript can do ERC20 and native bridging * ReceiverAcrossV3 + deploy script added (and deployed) * added dest calls on demoscript * ReceiverAcrossV3 updated (out-of-gas handling) & redeployed * ReceiverAcrossV3 updated (will revert for out-of-gas during swap exec) & redeployed * Successfully sent native+destCall with demoScript * simplified demo script to only use one fromChain * fixed failing test * fix spelling error in import * update forge coverage command in Github action * adds a check that ensures receiver addresses match in case of no dst call * solves stack-too-deep issue in GenericSwapFacetV3 test file (popped up due to solc upgrade) * adds destinationCallFlag validation * implements gas savings in ReceiverAcrossV3 and redeploys to staging * updates docs * removes coverage files as these should not be synced to github * gas optimization: use solady lib in ReceiverAcrossV3 * change min solc version to ^0.8.17 * removes native asset handling from receiver since this is not required for AcrossV3 * removes coverage files as these should not be synced to github * removes unused import * redeployed ReceiverAcrossV3 to arbitrum * updates CalldataVerificationFacet to support AcrossV3 * removes payable keyword (audit issue #13) * removes unused import (audit issue #4) * removes payable keyword from handleV3AcrossMessage function (audit issue #5) * removes unused import (audit issue #7) * adds more detailed explanations to revert handling in Receiver contract (audit issue #11) * narrows variable type (audit issue #9) * re-deploys facets to optimism staging * updates expected gas values in tests * trying to fix failing types action * undo last commit * updates typechain command in package.json * finally fixed $§%&$%§&$% CI issue * updates evm-version used for testing in Github action * updates evm-version used for testing in Github action #2 * removes forge coverage from github action (unused anyway) * disable PR reminder for PRs with label waitForBackend * redeployed AcrossFacetV3 and ReceiverAcrossV3 to OPT & POL staging * audit log updated and report added * Deploy AcrossV3 (except for zksync) * Deploy AcrossV3 packed (except for zksync) * Deploy to zksync * Deploy packed facet * add task to update approvals for AcrossFacetPackedV3 * Fix AcrossFacetPackedV3 script * update deploy requirements * Fix update scripts * Fix update scripts * Cleanup * fix imports * import paths updated for zkSync scripts * fixes one more import * adds ready_for_review triggers to git actions * adds support for exclusiveRelayer parameters * redeployed facets to arbitrum and optimism STAGING * update audit report (incl exclusivity relayer) * deployments to various networks * zksync deploy scripts updated * updates deploy script for AcrossFacetPackedV3 * proposed diamondCuts & periphery update to all relevant diamonds (except: zksync) * Deploy Across V3 to zkSync * update across demo scripts * Update logs for zksync * update coverage command in package.json * diamond logs updated * bump version of EmergencyPauseFacet * update pragma --------- Co-authored-by: Ed Zynda <ezynda3@gmail.com> Co-authored-by: Ed Zynda <ezynda3@users.noreply.github.com> Co-authored-by: Max Klenk <max@klenk.biz>
ezynda3
added a commit
that referenced
this pull request
Oct 28, 2024
* Implment and add tests for LibUtil::revertWith() * remove unneeded import * deploy to staging * temp - DO NOT PUSH * split facets, test files, deploy scripts etc. to V1/V3 * fix: replaces address parameter in facet * tests fixed * demoscript can do ERC20 and native bridging * ReceiverAcrossV3 + deploy script added (and deployed) * added dest calls on demoscript * ReceiverAcrossV3 updated (out-of-gas handling) & redeployed * ReceiverAcrossV3 updated (will revert for out-of-gas during swap exec) & redeployed * Successfully sent native+destCall with demoScript * simplified demo script to only use one fromChain * fixed failing test * fix spelling error in import * update forge coverage command in Github action * adds a check that ensures receiver addresses match in case of no dst call * solves stack-too-deep issue in GenericSwapFacetV3 test file (popped up due to solc upgrade) * adds destinationCallFlag validation * implements gas savings in ReceiverAcrossV3 and redeploys to staging * updates docs * removes coverage files as these should not be synced to github * gas optimization: use solady lib in ReceiverAcrossV3 * change min solc version to ^0.8.17 * removes native asset handling from receiver since this is not required for AcrossV3 * removes coverage files as these should not be synced to github * removes unused import * redeployed ReceiverAcrossV3 to arbitrum * updates CalldataVerificationFacet to support AcrossV3 * removes payable keyword (audit issue #13) * removes unused import (audit issue #4) * removes payable keyword from handleV3AcrossMessage function (audit issue #5) * removes unused import (audit issue #7) * adds more detailed explanations to revert handling in Receiver contract (audit issue #11) * narrows variable type (audit issue #9) * re-deploys facets to optimism staging * updates expected gas values in tests * trying to fix failing types action * undo last commit * updates typechain command in package.json * finally fixed $§%&$%§&$% CI issue * updates evm-version used for testing in Github action * updates evm-version used for testing in Github action #2 * removes forge coverage from github action (unused anyway) * disable PR reminder for PRs with label waitForBackend * redeployed AcrossFacetV3 and ReceiverAcrossV3 to OPT & POL staging * audit log updated and report added * Deploy AcrossV3 (except for zksync) * Deploy AcrossV3 packed (except for zksync) * Deploy to zksync * Deploy packed facet * add task to update approvals for AcrossFacetPackedV3 * Fix AcrossFacetPackedV3 script * update deploy requirements * Fix update scripts * Fix update scripts * Cleanup * fix imports * import paths updated for zkSync scripts * fixes one more import * adds ready_for_review triggers to git actions * adds support for exclusiveRelayer parameters * redeployed facets to arbitrum and optimism STAGING * update audit report (incl exclusivity relayer) * deployments to various networks * zksync deploy scripts updated * updates deploy script for AcrossFacetPackedV3 * proposed diamondCuts & periphery update to all relevant diamonds (except: zksync) * Deploy Across V3 to zkSync * update across demo scripts * Use foundry-zksync * Add missing floating pragmas and ignore tests and scripts when compiling for zksync * Use separate scripts for zksync * forge install: era-contracts * Fixes * Remove old scripts * Update verification and begin implementing create2 deployments * Try and predict address using system contract * Add remaining AcrossV3 deploy scripts * Add missing deploy scripts to zksync * Update logs * Update log for EmergencyPauseFacet * Auto build foundry-zksync docker image if it does not exist * Start adding special update scritps for zksync * Confirm deployment if already deployed * Redeploy EmergencyPauseFacet * Remove duplicates * Add comments and remove unfinished/incomplete scripts * Fix copy paste errors * Remove unused code * Update comments * Remove lcov dir * Add comment --------- Co-authored-by: Daniel Bläcker <d.blaecker@gmail.com> Co-authored-by: Max Klenk <max@klenk.biz>
0xDEnYO
added a commit
that referenced
this pull request
Sep 1, 2025
0xDEnYO
added a commit
that referenced
this pull request
Sep 12, 2025
…sSpokePoolV4 v1.0.0,ReceiverAcrossV4 v1.0.0] (#1299) * first draft AcrossFacetV4 * update interface * docs added * fix event and input validation * add deploy and update scripts for facet * added Across chainId for Solana * add ReceiverAcrossV4 * add initial test file for AcrossFacetV4 * add initial AcrossFacetPackedV4 and related files * remove max-line-length rule from linter * add constructor parameter validation * fix tests for AcrossFacetV4 * all existing tests fixed * add initial tests for outputMultiplier * reorg test files * all tests fixed * update licenses of deploy scripts * update deploy requirements * deployed to ARB/OPT staging * remove safeTransferLib from packed facet * add sendingAssetId in bytes32 as parameter * fix some tests * tests fixed * updated staging deployments * update AcrossV4 demoscript * update interface * update deploy log * rename test case * fix comments in demo script * smaller fixes * add constructor parameter validation to packed facet * add missing validation for parameter * use existing helper function to access deployments * fix Receiver docs file * added type helpers for bridgeData in demoScripts * add receiver address validation * remove failing (outdated) LibAsset test * add non-0 receiver address validation * add tests to increase coverage * add test API URL * redeployed AcrossV4 to staging * fixed demo script * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests * fix demo script * update license identifier * use consola instead of console * Update test/solidity/Facets/Across/V4/AcrossFacetV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comment updated (audit issue #1) * added refundAddress validation (and disclaimer in packed facet) * added disclaimer (audit issue #3) * replace hardcoded value with constant (audit issue #4) * replace exclusivityDeadline with exclusivityParameter (audit issue #5) * update data length validation (audit issue #6) * removed sendingAssetId from PackedParameters struct (audit issue #7) * redeployed to ARB staging * fix docs * Update script/demoScripts/demoAcrossV4.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * another docs fix * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * rename tests * Update test/solidity/Facets/Across/V4/AcrossFacetV4OutputAmountIntegration.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fixed tests * update logic in AcrossFacetPacked to allow long destinationChainIds such as Solana * fix unit tests * update docs * added tests to Solana for AcrossFacetPacked * Update docs/AcrossFacetPackedV4.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * set outputAmount explicitly * fix integration tests * fix docs * fix issue in test * OPT staging update * PR cleanup * remove temporary test file * redeployed packed facet to OPT/ARB staging * remove unnecessary comments and type conversions * fix comment (audit issue #11) * add evm vs non-evm distinction to decoding functions (audit issue #12) * audit report added * fix json * remove unrelated filess --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
0xDEnYO
added a commit
that referenced
this pull request
Sep 16, 2025
* first draft AcrossFacetV4 * update interface * docs added * fix event and input validation * add deploy and update scripts for facet * added Across chainId for Solana * add ReceiverAcrossV4 * add initial test file for AcrossFacetV4 * add initial AcrossFacetPackedV4 and related files * remove max-line-length rule from linter * add constructor parameter validation * fix tests for AcrossFacetV4 * all existing tests fixed * add initial tests for outputMultiplier * reorg test files * all tests fixed * update licenses of deploy scripts * update deploy requirements * deployed to ARB/OPT staging * remove safeTransferLib from packed facet * add sendingAssetId in bytes32 as parameter * fix some tests * tests fixed * updated staging deployments * update AcrossV4 demoscript * update interface * update deploy log * rename test case * fix comments in demo script * smaller fixes * add constructor parameter validation to packed facet * add missing validation for parameter * use existing helper function to access deployments * fix Receiver docs file * added type helpers for bridgeData in demoScripts * add receiver address validation * remove failing (outdated) LibAsset test * add non-0 receiver address validation * add tests to increase coverage * add test API URL * redeployed AcrossV4 to staging * fixed demo script * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests * fix demo script * update license identifier * use consola instead of console * Update test/solidity/Facets/Across/V4/AcrossFacetV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comment updated (audit issue #1) * added refundAddress validation (and disclaimer in packed facet) * added disclaimer (audit issue #3) * replace hardcoded value with constant (audit issue #4) * replace exclusivityDeadline with exclusivityParameter (audit issue #5) * update data length validation (audit issue #6) * removed sendingAssetId from PackedParameters struct (audit issue #7) * redeployed to ARB staging * fix docs * Update script/demoScripts/demoAcrossV4.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * another docs fix * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * rename tests * Update test/solidity/Facets/Across/V4/AcrossFacetV4OutputAmountIntegration.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fixed tests * update logic in AcrossFacetPacked to allow long destinationChainIds such as Solana * fix unit tests * update docs * added tests to Solana for AcrossFacetPacked * Update docs/AcrossFacetPackedV4.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * set outputAmount explicitly * fix integration tests * fix docs * fix issue in test * OPT staging update * PR cleanup * remove temporary test file * redeployed packed facet to OPT/ARB staging * remove unnecessary comments and type conversions * fix comment (audit issue #11) * add evm vs non-evm distinction to decoding functions (audit issue #12) * audit report added * fix json * remove unrelated filess * add helper functions for multichain (and -evm) execution * deployed to lens * deployed to zksync * deployed to 3 cancun networks * deployed 12 london networks * verified zksync * diamond logs updated * remove unrelated files --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.