Separate Axelar from Executor #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xDEnYO
added a commit
that referenced
this pull request
Sep 13, 2024
0xDEnYO
added a commit
that referenced
this pull request
Oct 8, 2024
….0.0) (#715) * feat: adds EmergencyPauseFacet * removes unused diamond cut code * introduces LibDiamondLoupe to avoid external calls for loupe functions * cleanup * registered EmergencyPauseFacet in BSC staging diamond * adds github action that allows to manually pause the diamond from Github UI * add team membership verification to git action * remove push event trigger from git action * removes unused imports (audit issue#2) * optimizes modifier (audit issue#3) * adds indexed keyword to events (audit issue#5) * inlines a helper function that is only used once (audit issue#6) * removes unused helper function (audit issue#7) * removes unnecessary delete statement (audit issue#11) * adds check to prevent accidental removal of EmergencyPauseFacet * adds a check to prevent accidental removal of DiamondCutFacet while unpausing (audit issue#13) * adds test to increase test coverage to 100% (audit issue #15) * removes duplicate function in helperFunctions.sh * minor fixes * adds a test case that checks how many facets we can pause * remove playground.sh (accidentally committed before) * removes TODO and adds comment * adds a check to prevent pausing twice * used diamondCut function to remove facets so events get emitted (audit issue #12) * audit report added and log updated * emergencyPause script updates and staging deployments * Update script/tasks/diamondEMERGENCYPause.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * remove placeholder git action * minor fixes from coderabbit reviews * add fake audit entry to make PR mergable * add 2nd fake audit entry to make PR mergable * update warning message text * test * test * test * revert changes --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
0xDEnYO
added a commit
that referenced
this pull request
Sep 1, 2025
0xDEnYO
added a commit
that referenced
this pull request
Sep 12, 2025
…sSpokePoolV4 v1.0.0,ReceiverAcrossV4 v1.0.0] (#1299) * first draft AcrossFacetV4 * update interface * docs added * fix event and input validation * add deploy and update scripts for facet * added Across chainId for Solana * add ReceiverAcrossV4 * add initial test file for AcrossFacetV4 * add initial AcrossFacetPackedV4 and related files * remove max-line-length rule from linter * add constructor parameter validation * fix tests for AcrossFacetV4 * all existing tests fixed * add initial tests for outputMultiplier * reorg test files * all tests fixed * update licenses of deploy scripts * update deploy requirements * deployed to ARB/OPT staging * remove safeTransferLib from packed facet * add sendingAssetId in bytes32 as parameter * fix some tests * tests fixed * updated staging deployments * update AcrossV4 demoscript * update interface * update deploy log * rename test case * fix comments in demo script * smaller fixes * add constructor parameter validation to packed facet * add missing validation for parameter * use existing helper function to access deployments * fix Receiver docs file * added type helpers for bridgeData in demoScripts * add receiver address validation * remove failing (outdated) LibAsset test * add non-0 receiver address validation * add tests to increase coverage * add test API URL * redeployed AcrossV4 to staging * fixed demo script * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests * fix demo script * update license identifier * use consola instead of console * Update test/solidity/Facets/Across/V4/AcrossFacetV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comment updated (audit issue #1) * added refundAddress validation (and disclaimer in packed facet) * added disclaimer (audit issue #3) * replace hardcoded value with constant (audit issue #4) * replace exclusivityDeadline with exclusivityParameter (audit issue #5) * update data length validation (audit issue #6) * removed sendingAssetId from PackedParameters struct (audit issue #7) * redeployed to ARB staging * fix docs * Update script/demoScripts/demoAcrossV4.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * another docs fix * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * rename tests * Update test/solidity/Facets/Across/V4/AcrossFacetV4OutputAmountIntegration.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fixed tests * update logic in AcrossFacetPacked to allow long destinationChainIds such as Solana * fix unit tests * update docs * added tests to Solana for AcrossFacetPacked * Update docs/AcrossFacetPackedV4.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * set outputAmount explicitly * fix integration tests * fix docs * fix issue in test * OPT staging update * PR cleanup * remove temporary test file * redeployed packed facet to OPT/ARB staging * remove unnecessary comments and type conversions * fix comment (audit issue #11) * add evm vs non-evm distinction to decoding functions (audit issue #12) * audit report added * fix json * remove unrelated filess --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
0xDEnYO
added a commit
that referenced
this pull request
Sep 16, 2025
* first draft AcrossFacetV4 * update interface * docs added * fix event and input validation * add deploy and update scripts for facet * added Across chainId for Solana * add ReceiverAcrossV4 * add initial test file for AcrossFacetV4 * add initial AcrossFacetPackedV4 and related files * remove max-line-length rule from linter * add constructor parameter validation * fix tests for AcrossFacetV4 * all existing tests fixed * add initial tests for outputMultiplier * reorg test files * all tests fixed * update licenses of deploy scripts * update deploy requirements * deployed to ARB/OPT staging * remove safeTransferLib from packed facet * add sendingAssetId in bytes32 as parameter * fix some tests * tests fixed * updated staging deployments * update AcrossV4 demoscript * update interface * update deploy log * rename test case * fix comments in demo script * smaller fixes * add constructor parameter validation to packed facet * add missing validation for parameter * use existing helper function to access deployments * fix Receiver docs file * added type helpers for bridgeData in demoScripts * add receiver address validation * remove failing (outdated) LibAsset test * add non-0 receiver address validation * add tests to increase coverage * add test API URL * redeployed AcrossV4 to staging * fixed demo script * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests * fix demo script * update license identifier * use consola instead of console * Update test/solidity/Facets/Across/V4/AcrossFacetV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comment updated (audit issue #1) * added refundAddress validation (and disclaimer in packed facet) * added disclaimer (audit issue #3) * replace hardcoded value with constant (audit issue #4) * replace exclusivityDeadline with exclusivityParameter (audit issue #5) * update data length validation (audit issue #6) * removed sendingAssetId from PackedParameters struct (audit issue #7) * redeployed to ARB staging * fix docs * Update script/demoScripts/demoAcrossV4.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * another docs fix * Update test/solidity/Facets/Across/V4/AcrossFacetPackedV4.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * rename tests * Update test/solidity/Facets/Across/V4/AcrossFacetV4OutputAmountIntegration.t.sol Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fixed tests * update logic in AcrossFacetPacked to allow long destinationChainIds such as Solana * fix unit tests * update docs * added tests to Solana for AcrossFacetPacked * Update docs/AcrossFacetPackedV4.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * set outputAmount explicitly * fix integration tests * fix docs * fix issue in test * OPT staging update * PR cleanup * remove temporary test file * redeployed packed facet to OPT/ARB staging * remove unnecessary comments and type conversions * fix comment (audit issue #11) * add evm vs non-evm distinction to decoding functions (audit issue #12) * audit report added * fix json * remove unrelated filess * add helper functions for multichain (and -evm) execution * deployed to lens * deployed to zksync * deployed to 3 cancun networks * deployed 12 london networks * verified zksync * diamond logs updated * remove unrelated files --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.