refactor: replaced custom revert strings with errors #48 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H3xept
changed the title
Contributor
|
@H3xept Please fix compilation errors. |
0xDEnYO
added a commit
that referenced
this pull request
Sep 10, 2024
0xDEnYO
added a commit
that referenced
this pull request
Oct 8, 2024
….0.0) (#715) * feat: adds EmergencyPauseFacet * removes unused diamond cut code * introduces LibDiamondLoupe to avoid external calls for loupe functions * cleanup * registered EmergencyPauseFacet in BSC staging diamond * adds github action that allows to manually pause the diamond from Github UI * add team membership verification to git action * remove push event trigger from git action * removes unused imports (audit issue#2) * optimizes modifier (audit issue#3) * adds indexed keyword to events (audit issue#5) * inlines a helper function that is only used once (audit issue#6) * removes unused helper function (audit issue#7) * removes unnecessary delete statement (audit issue#11) * adds check to prevent accidental removal of EmergencyPauseFacet * adds a check to prevent accidental removal of DiamondCutFacet while unpausing (audit issue#13) * adds test to increase test coverage to 100% (audit issue #15) * removes duplicate function in helperFunctions.sh * minor fixes * adds a test case that checks how many facets we can pause * remove playground.sh (accidentally committed before) * removes TODO and adds comment * adds a check to prevent pausing twice * used diamondCut function to remove facets so events get emitted (audit issue #12) * audit report added and log updated * emergencyPause script updates and staging deployments * Update script/tasks/diamondEMERGENCYPause.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * remove placeholder git action * minor fixes from coderabbit reviews * add fake audit entry to make PR mergable * add 2nd fake audit entry to make PR mergable * update warning message text * test * test * test * revert changes --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.