chore(SymbiosisFacet): prod deploy + cut of v2.0.0 to 37 chains (EXSC-267) - #2108
Conversation
…s (EXSC-267) Deploy-only (bytecode + explorer verify + deployment-log address maps). diamondCut proposals deferred to a later multisig rollout gated on the backend OnchainSwapV3 cutover (waitForBackend). No Safe/multisig proposals created; no <chain>.diamond.json registries changed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (54)
WalkthroughUpdated the ChangesSymbiosisFacet deployment manifest updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tron deploy via contracts-tron fork (deferred-cut, no diamondCut proposal). SymbiosisFacet v2.0.0 -> TMY1N6rC61Fu1C8qvZEhwb3WLR7iY1ERuW (tx a340a2f0b558...). tron.diamond.json registry unchanged (cut deferred to backend cutover). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
0xDEnYO
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployments/tron.json`:
- Line 13: Reconcile the Tron deployment metadata for SymbiosisFacet: remove or
revert the committed entry if the cut remains deferred, or document the
deployment intent without implying an immediate diamond-cut proposal. Ensure
deployments/tron.json and deployments/tron.diamond.json no longer contain
conflicting SymbiosisFacet addresses.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: addb980d-9769-4412-9a90-786d5a5bed51
📒 Files selected for processing (1)
deployments/tron.json
…-v2.0.0-prod # Conflicts: # deployments/base.json # deployments/robinhood.json
…-v2.0.0-prod # Conflicts: # deployments/unichain.json
…SC-267) Reflect on-chain facetAddresses() after the production timelock executions landed SymbiosisFacet v2.0.0 on 37 networks. Co-authored-by: Cursor <cursoragent@cursor.com>
0xDEnYO
changed the title
Resolve zksync.diamond.json by regenerating from on-chain state after SymbiosisFacet v2.0.0 cut. Co-authored-by: Cursor <cursoragent@cursor.com>
Address-consistency CI failed because the SymbiosisFacet diamond-log sync picked up the already-executed AllBridgeFacet v2.2.0 cut on tron while deployments/tron.json still pointed at v2.1.1. Co-authored-by: Cursor <cursoragent@cursor.com>
3 participants
Which Linear task belongs to this PR?
EXSC-267
Why did I implement it this way?
PRODUCTION deploy + cut of
SymbiosisFacetv2.0.0 (merged in #2045: adds the backend-EIP712-signature-gatedOnchainSwapV3syBTC→Bitcoin path,IOnchainSwapV3v1.0.0).Originally shipped as a deferred-cut deploy (bytecode + explorer verification +
deployments/<chain>.jsonaddress maps only) while the backendOnchainSwapV3cutover was pending. The production diamondCuts have now executed via the multisig → timelock pipeline on all 37 in-scope chains; this PR additionally syncs the on-chaindeployments/<chain>.diamond.jsonregistries (facetAddresses proof ofSymbiosisFacetv2.0.0).Note: the cut Adds the new selectors onto the v2.0.0 facet address; the prior v1.0.0 facet address may still appear in
facetAddresses()where older selectors remain wired — both entries in the diamond log are expected.Deploy board — 37 / 37 in-scope chains deployed + cut ✅
Every deployed address was checked with
cast code(Tron via troncast): all 37 contain bytecode on-chain. Timelock queue + on-chainisOperationDoneverified executed for all 37. Diamond logs regenerated from on-chain state for all 37.Verification note (9 chains): deploy succeeded and on-chain bytecode is present; automated explorer verification is blocked by explorer-side obstacles (cronos Cloudflare, telos sourcify mismatch, gravity oklink, metis/mode routescan, scroll etherscan-v2, abstract zkSync explorer, tron Tronscan).
Excluded per scope:
taiko(deprecating),polygonzkevm(not cut into its diamond).EVM deployer:
0xb05E63458A51731Aad26BdcD6E12246330E6095F.Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)