chore(deploy): add OutputValidator v1.0.0 on robinhood - #2132
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughRobinhood deployment metadata now records deployed ChangesRobinhood contract metadata
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…0 cut execution [EXSC-685] Registration + allowlist timelock ops executed on-chain (safeTxHash 0xfe8aa8c8…, 0x1c3bb518…). Regenerated from on-chain state; robinhood also shows ReceiverOIF from the sibling rollout #2136 (both now live on the diamond). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployments/robinhood.diamond.json`:
- Line 99: Update the Robinhood whitelist’s PERIPHERY entry in
config/whitelist.json to include the deployed ReceiverOIF address from the
ReceiverOIF field in deployments/robinhood.diamond.json, along with its selector
layout; if it is not intended for registration, clear the snapshot’s ReceiverOIF
field instead so consistency validation passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 92640c24-f66a-4560-bf29-380ec00c5745
📒 Files selected for processing (3)
config/whitelist.jsondeployments/robinhood.diamond.jsondeployments/robinhood.json
Drop the ReceiverOIF entry that on-chain regeneration pulled in; it belongs to the sibling rollout #2136. Keeps this PR consistent with its own flat log + whitelist (address-consistency gate). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ler-e4cd5a Resolves deployments/robinhood.json conflict by keeping both ReceiverOIF (this branch) and OutputValidator (main, #2132). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Which Linear task belongs to this PR?
Fixes EXSC-685
Why did I implement it this way?
OutputValidatoris core periphery (config/global.json→corePeriphery) and the production target-state Google Sheet lists it at1.0.0for all 75 networks — but it was never deployed to robinhood, so the diamond had no validator to call. This PR closes that gap: the contract is now deployed, verified, and proposed for registration + allowlisting on robinhood.Robinhood fell through two separate cracks. It was brought up on 2026-06-25 in #1849 (then still named
outlaw), which was after the OutputValidator fleet rollout of ~2026-06-09, so it wasn't part of that batch. And the new-network bring-up readsscript/deploy/_targetState.json, which is stale relative to the sheet — OutputValidator is missing from it for all 75 networks (along with 161 other sheet entries, e.g.LiFiIntentEscrowFacetV2on 63 networks andPolymerCCTPFaceton 16), so nothing in the automated path ever deployed it either. Regenerating that file from the sheet is deliberately left out of this PR to keep the diff to one concern; it's worth doing separately, since the drift currently hides this whole class of gap on every network.State verified on-chain before deploying, so this isn't a log-only discrepancy:
getPeripheryContract("OutputValidator")on the diamond returned0x0, and there was no code at the address. Deployment used the standard CREATE3 path; the resulting address differs from other chains, which is normal for this contract (the 74 chains that have it span roughly 20 distinct addresses, since the salt varies with the build).Production
0x321E5015072eB568B24F46e5A92FFcc4316056ABBoth proposals are timelock-wrapped
scheduleBatchcalls onLiFiTimelockController0x6E9Beb6997dAE04122f1f8f8980f3dc8225443F3(3h minimum delay), each currently carrying a single signature and awaiting the usual signing round.The
config/whitelist.jsondiff addsOutputValidatorfor robinhood with selectors0x27444dab(validateERC20Output(address,uint256,address)) and0x5d865df2(validateNativeOutput(uint256,address)). It ships here because proposal 21 is derived from it — registration alone does not let the diamond call the contract.The contract is verified on Blockscout, and its constructor owner is
0x156CeBba59DEB2cB23742F70dCb0a11cC775591F, matchingglobal.json→refundWalletasdeployRequirements.jsonspecifies. Productiondeployments/robinhood.diamond.jsonwill only pick up the new periphery entry once the cuts actually execute, so it is intentionally not touched here.Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)